This is the week before go-live with a large customer. They've been doing lots of testing on their end (refreshing), and in the final stretch they found two glaring issues.
These two issues were glaringly, obviously wrong in core modules, and 100% reproducible.
Both were bad queries (static but parameterized). One resulted in an error from the DB server, and the other was a full join rather than filter by parameter (x=x vs x=:x), so spectacularly wrong results. Both were triggered by doing typical operations in our application.
Both issues had been in our code for many, many months, yet somehow the thousands of users we have across our several hundred customers somehow didn't report or experience these issues.
I fixed both issues in less than 15 minutes.
This isn't the first time. Sometimes I'm amazed how long such glaring issues manages to survive out in the wild amongst our customers.
Not saying they didn't know. Just saying that sometimes these things just happen.
I spent so much time in cities.exe I'm scared to check out the second one. How do you feel about the modding scene for it? I had probably 70GB of assets loading, converting the game into something altogether different.
These two issues were glaringly, obviously wrong in core modules, and 100% reproducible.
Both were bad queries (static but parameterized). One resulted in an error from the DB server, and the other was a full join rather than filter by parameter (x=x vs x=:x), so spectacularly wrong results. Both were triggered by doing typical operations in our application.
Both issues had been in our code for many, many months, yet somehow the thousands of users we have across our several hundred customers somehow didn't report or experience these issues.
I fixed both issues in less than 15 minutes.
This isn't the first time. Sometimes I'm amazed how long such glaring issues manages to survive out in the wild amongst our customers.
Not saying they didn't know. Just saying that sometimes these things just happen.